FreeEMS-Tuner Development Diary - Comments

Aaron Barnes' wxPython based FreeEMS tuning tool. No longer maintained and out of date with the protocol requirements.
User avatar
sry_not4sale
LQFP144 - On Top Of The Game
Posts: 568
Joined: Mon Mar 31, 2008 12:47 am
Location: New Zealand, land of the long white burnout
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by sry_not4sale »

Fred wrote:You aren't responding to your MSN so I'm posting here as well.

The old branch works mint now :-) Yay.

The new one barfs on connect like the serial connection code is not there or something.

More testing tomorrow night I guess.

Fred.
Fixed the error you sent me, changed a method to be private and didn't update some of the calls.
Owner / Builder: 1983 Mazda Cosmo 12at (1200cc 2-rotor turbo) coupe [SPASTK]
165hp @ 6psi standard - fastest production car in japan Oct 82
User avatar
Fred
Moderator
Posts: 15433
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by Fred »

sry_not4sale wrote:Fixed the error you sent me, changed a method to be private and didn't update some of the calls.
There must be some sort of "compiler" available for python so you can check for that sort of undefined reference up front?

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
jbelanger
LQFP144 - On Top Of The Game
Posts: 387
Joined: Sat Feb 23, 2008 8:58 pm
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by jbelanger »

I'm sorry I posted in the other thread so please delete it.

What I wanted to say is this:

A little nit-picking from the non-English native: the right term is deprecate. I have seen the use of depreciate in a few places and it always seemed strange so I checked.

And by the way, do correct me on any mistake I may make. I'd rather have a friendly correction than continue to look like a knob for making stupid mistakes.

Jean
User avatar
sry_not4sale
LQFP144 - On Top Of The Game
Posts: 568
Joined: Mon Mar 31, 2008 12:47 am
Location: New Zealand, land of the long white burnout
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by sry_not4sale »

Your spot on :D

Thanks!
Owner / Builder: 1983 Mazda Cosmo 12at (1200cc 2-rotor turbo) coupe [SPASTK]
165hp @ 6psi standard - fastest production car in japan Oct 82
User avatar
Fred
Moderator
Posts: 15433
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by Fred »

Nit picking is good! If the person receiving can't take it they can get fcuked!! PS, my new boss rocks :-)

Clearly Aaron can't get fcuked! Neither can I... woops.

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15433
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by Fred »

sry_not4sale wrote:This will be good for making sure Fred's code is bug free also
Oh come on man, my code *never* has bugs ;-)
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
BenFenner
LQFP144 - On Top Of The Game
Posts: 360
Joined: Wed Jul 09, 2008 3:15 pm

Re: FreeEMS-Tuner Development Diary - Comments

Post by BenFenner »

sry_not4sale wrote:My current ideas for testing are:
  • The test comms plugin will take the raw packets sent to it and reparse them back into classes as another test to make sure my code works as expected and the correct bytes are sent out.
  • The test comms plugin will "reply" to sent packets with their appropriate responses defined in the protocol
  • The test framework will create a second comms connection using the test plugin (I added support for multiple comms connections when I moved to threaded code) and will send packets to both comms connections to compare the real responses with the expected response. This will be good for making sure Fred's code is bug free also
  • Great idea. I was considering this as well.
  • Great idea. I was really upset it didn't do this to begin with. ;)
  • Pretty good idea. Would depend if Fred wanted it or not.
Last edited by Fred on Wed Jan 14, 2009 11:34 pm, edited 1 time in total.
Reason: fix list
User avatar
Fred
Moderator
Posts: 15433
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by Fred »

BenFenner wrote:
  • Pretty good idea. Would depend if Fred wanted it or not.
It's a good idea provided it can keep up. I'm yet to test the performance of the new code, so we'll see how it goes.

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15433
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by Fred »

Good work!

You had me all excited there for a second until I read that I had already tested all that stuff LOL. Clearly I missed your post somehow ;-)

Perhaps I should quickly fire it up now?

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15433
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: FreeEMS-Tuner Development Diary - Comments

Post by Fred »

Sorry to hear that, is it for sale?
sry_not4sale wrote:Hard drive is ok thank god
Of course, that wouldn't matter because you back it up nightly with rsync right?? :-p

Dead laptops are great. Clearly there is a need to own three at a time such that there is a good chance one will always at least sort of work.

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
Post Reply