FreeEMS-Tuner Development Diary - Comments

[sry_not4sale]

It's all good. It's incomplete, but has the threading/controller code in there

I'll upload it as an attachment here sometime soon.. just to keep you waiting

[sry_not4sale]

Here ya go. Don't run it long, as it doesn't do anything really - and it pours out debug messages to console.

Major changes are in:
controller.py
libs/thread.py

and the new thread safe config in:
actions/*
libs/config.py
gui/settings.py

[Fred]

First feedback :

Looks the same as before, however when i put my config into the data dir it barfs :

Code: Select all

fred@rwdlsd:~/Desktop/tuner/freeems-threaded$ python main.py 
Traceback (most recent call last):
  File "main.py", line 31, in <module>
    ctr = controller.app()
  File "/home/fred/Desktop/tuner/freeems-threaded/controller.py", line 63, in __init__
    comms.createConnection(self)
  File "/home/fred/Desktop/tuner/freeems-threaded/comms/__init__.py", line 41, in createConnection
    _connection[name] = __import__(type, globals(), locals(), 'connection').connection(type, controller)
TypeError: __init__() takes exactly 2 arguments (3 given)

my file just has serial instead of test and the device name, nothing else. well, maybe the debug is dff

Code: Select all

fred@rwdlsd:~/Desktop/tuner/freeems-threaded.borked2/data$ diff my_config.ini.*

7,12c7

< default = Serial

< 

< [Comms_Serial]

< # Filepath to serial-like port

< port = /dev/ttyUSB0

< 

---

> default = Test

Cheers, will play later :-)

Fred.

[sry_not4sale]

Serial module is incomplete, you will have to use the Test module.

This is really just for code review, not for testing.

[sry_not4sale]

I think you might be confused in thinking this is complete... lol its not Still have a bit to do !

[Fred]

Oh, I just assumed it would have the same code as before rearranged into threaded chunks and isolated properly. I guess this means that the serial code will be new and super duper? If so, does that mean the checksum/escape bug will be gone? If so, wicked :-) I'm pretty far from my test rig right now anyway, so no rush on that, you have a few days, and I have lots to do also :-)

Cheers for the test code. I can confirm that it starts up and looks fine! Well done getting this far with the threading exercise. I'm looking forward to the next tar ball.

Fred.

[Fred]

Sounds excellent :-) I can't wait to reset my device with it lol. The next step (after its working solidly in a basic way with that checksum issue fixed) is some internal data structures so we can handle in and out going tuning data. Then interfaces for them and we are golden for some actual tuning in a few weeks :-)

Oh, btw, Marcos was supposed to be running his car with his diy efi ecu today. I wonder how he got on? He said he'd be using his tuning tool and would start porting it to FreeEMS fairly soon. Gotta love open source competition don't ya :-)

Yours will always be more convenient in terms of test/dev builds though as his takes quite a while to build/compile.

That ought to keep you on your toes :-)

Fred.

[sry_not4sale]

I'm already on my toes hahaha

All good mate

[Fred]

"threads left running" - you shouldn't need to do anything to ensure when it exits it exits. child parent threads are the default afaik. Thanks for putting that up!

Fred.

[Fred]

You aren't responding to your MSN so I'm posting here as well.

The old branch works mint now :-) Yay.

The new one barfs on connect like the serial connection code is not there or something.

More testing tomorrow night I guess.

Fred.