Phil's missing teeth decoder dev thread

Official FreeEMS vanilla firmware development, the heart and soul of the system!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Phil's missing teeth decoder dev thread

Post by Fred »

I thought I'd start this in the firmware section :-)

I just loaded an s19 built from the source you gave me, only to realise that I can't test it because my board is still in pieces...

I'll try to finish the wiring and soldering tomorrow night.

Sorry for the delay.

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
johnsop1
DIP8 - Involved
Posts: 26
Joined: Tue Jan 13, 2009 1:56 am

Re: Phil's missing teeth decoder dev thread

Post by johnsop1 »

Sorry for the delay
No sweat.

The code syncs on the pulses that I am putting out on my LPT port, but the jumstim should be a better test.

If it works for you, my next step is to calculate rpm and figure out how to trigger ignition.
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: Phil's missing teeth decoder dev thread

Post by Fred »

OK, I'll do my best to get that tested tomorrow.

As for ignition, it might pay to hold off and start with fueling from it. I intend to write a scheduling implementation pretty soon, right after the comms stuff is cleared up.

Also, you seem to be making arbitrary white space changes, by the looks of it automatically by your tool of choice. I'll have to get the eclipse formatter sorted out properly so we can automatically conform to the same standard.

http://github.com/johnsop1/freeems-vani ... 60531df3e9

I've got a stack of work underway right now, but I'm getting there :

Code: Select all

/home/user/workspaces/home/freeems-vanilla> git branch
  RPMInputPinSwap0-7
  aaronb
  commsChangesPlusReleaseMakefileChanges
  master
  philsMissingTooth
* philsmaster
  public
  release
  seank
  unitTestingExperimentation
With a bit of luck I'll be getting close tomorrow and happy to push up your stuff merged with mine and some new stuff from me too.

Actually, you know what, I merged and pushed my changes up :-) I added your name to the copyright and author tag and fixed the indentation of the gnu notice and reverted the comms change.

In order to get in sync again you should create a local branch back a few commits

git branch fredsmaster 7c1bf96df33cbbe06dd82ef0afcd0bd3e31a6082

Then add a remote for my public repo git url

Then setup the fredsmaster branch to pull from that remote/master

Then

git checkout fredsmaster

git pull

If you have uncommitted changes you should git stash them before switching branches with checkout.

After you have pulled it down to it's own branch, you can switch back to your branch and do

git merge fredsmaster

which will bring out histories into alignment. then carry on working, committing and pushing :-)

Oh, and you had better get yourself an ohloh account and claim your commits :-)

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
johnsop1
DIP8 - Involved
Posts: 26
Joined: Tue Jan 13, 2009 1:56 am

Re: Phil's missing teeth decoder dev thread

Post by johnsop1 »

Also, you seem to be making arbitrary white space changes, by the looks of it automatically by your tool of choice. I'll have to get the eclipse formatter sorted out properly so we can automatically conform to the same standard.
You are correct, I used eclipse to reformat. I would be happy to use a standard formatted if you set one up.
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: Phil's missing teeth decoder dev thread

Post by Fred »

Since your post you went and commited and pushed some more, so I had to remerge and repush. I've done that now. Please branch, pull and merge so we are on the same page again :-)

The way I typically work with eclipse is to let it format the code that I write. I rarely use the format all function as it does funny stuff like randomly mess with comments :-)

I'm sure you also know that you can select N lines of text and hit ctrl I to indent it.

Anyway, that is enough push, pull, etc for one night, it's 230am here and I'm getting up in 3 hours...

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: Phil's missing teeth decoder dev thread

Post by Fred »

OK Phil, my test rig is working again at least sort of, so I can probably (I'll make sure of it) test your code tomorrow, not to mention get on with some of my own and various other things :-)

Just thought I'd let you know.

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
johnsop1
DIP8 - Involved
Posts: 26
Joined: Tue Jan 13, 2009 1:56 am

Re: Phil's missing teeth decoder dev thread

Post by johnsop1 »

Sounds good,

I am looking forward to the results (good or bad).
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: Phil's missing teeth decoder dev thread

Post by Fred »

Hi,

I fired it up and did the following :

steady rpm at low medium and high = no sync
varying rpm going up slowly and quickly = no sync
varying rpm going down from high revs = no sync
varying rpm going down from low revs quicly = brief sync

Additionally I tried with the signal inverted and with 60-2 and 60-2 inverted = same results pretty much.

Interestingly when I loaded my toyota code with the 60 and 36 pattern and at low rpm it won't sync, but at higher rpm sync comes on and off continuously. I doubt that is a problem though as no one would ever get far with 50% fuel and no starting rpm signal. Plus they'd be dumb if they loaded the entire wrong s19 file :-)

I'm going to rip the signal inversion code out of mine as per the discussion a while back and continue development on the basis that inversion will be done in hardware if/when required. I suggest you do the same, or I can do it for you if you like (maybe it's already gone?).

Regards,

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: Phil's missing teeth decoder dev thread

Post by Fred »

As a further experiment I tried 36-2-2-2 against your code and my own. Mine showed no signs of life, and yours was much more difficult to make flash on briefly. I then tried 24/2 against yours and it didn't come on at all.

I guess the key point is that it is seeing gaps, but not the right size or count in between or something.

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: Phil's missing teeth decoder dev thread

Post by Fred »

I'm certain that you already know this and are doing it, but for the benefit of others reading and the slim chance that you didn't realise :

fred@rwdlsd:~/workspaces/home/freeems-vanilla/src$ make firmware/freeems-0.0.20-NipponDenso.s19
make: `firmware/freeems-0.0.20-NipponDenso.s19' is up to date.

Is much faster when you change one file and only want to test what you are working on :-)

Shall I split this into a comments thread and main thread so I don't spam it too much?

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
Post Reply