FreeEMS Configuration Rules

Official FreeEMS vanilla firmware development, the heart and soul of the system!
Post Reply
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

FreeEMS Configuration Rules

Post by Fred »

VEMS has a system which, though poorly implemented, I quite like. Their tuning software has a checker in it that can run over all of the config and look for things that violate predetermined rules. This thread is here to attempt to list some of the rules that we will need for FreeEMS. There will be a large number in order to do this thoroughly, however even a small subset is a healthy thing to have.

Errors

Errors should prevent the user from sending values to the device and should display in red and/or caps and/or bold.
  • Hysteresis < Threshold
  • Decoder to engine offset < decoder total angle
  • Ignition timing < 10*BTDC for GM DIS
  • Rev limit ignition cut re-enable > Rev limit injection cut re-enable (fuel should start flowing before sparks)
  • XGATE and/or S12X and/or ISR functions attempting to share the same ports
  • Sensor source config values are valid (< lastValid+1)
Warnings

Warnings should be displayed prominently in yellow/orange and/or bold, but should not prevent the user proceeding.
  • Ignition timing > some curve of thresholds for a typical engine
Feel free to post your ideas and thoughts on particular rules and I'll add them to this post.

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: FreeEMS Configuration Rules

Post by Fred »

I intend to enforce this in the firmware now. http://issues.freeems.org/view.php?id=615

If there are any legit warnings, perhaps those should be handled on the PC, or perhaps we need a warning packet type or similar.

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
Post Reply