DIYEFI.org Forum
http://forum.diyefi.org/

examples of bad code (and why) ?
http://forum.diyefi.org/viewtopic.php?f=45&t=816
Page 3 of 3

Author:  Peter [ Sat Jun 09, 2012 5:54 am ]
Post subject:  Re: examples of bad code (and why) ?

Fred wrote:
throw an "unreachable code" error ;-)

I saw that, and for some reason I thought that you were commenting on misspelling or something. Then about 45 seconds later I got the joke. I think I've only actually seen that compiler error once.

Author:  Fred [ Sat Jun 09, 2012 2:01 pm ]
Post subject:  Re: examples of bad code (and why) ?

Having a slow day? :-)

Author:  Fred [ Thu Oct 25, 2012 2:43 pm ]
Post subject:  Re: examples of bad code (and why) ?

I found this on the interwebs:

Code:
if (i<3 && b<0) {}

Bad variable naming, times two, plus magic number, times one, equals meaningless code.

Fred.

Author:  Fred [ Mon Nov 05, 2012 5:02 pm ]
Post subject:  Re: examples of bad code (and why) ?

Pointless code:

Code:
for (int i = 0; i < 1; i++) {
    // Lots of code, none of which referenced 'i'
}

Whose code is this, you ask? Mine! :-o

How the hell that made it near a source file I have NO idea. Possibly auto-generated or possibly a hang over from a loop with more than 1 in it?

It's gone now...

Fred.

Author:  Fred [ Tue Dec 11, 2012 10:10 am ]
Post subject:  Re: examples of bad code (and why) ?

Not really bad code per se, but:

Code:
[WARNING] Messages.java:247: warning - @param argument "a" is not a parameter name.
[WARNING] Messages.java:247: warning - @param argument "the" is not a parameter name.

Tell me why I got these warnings? :-)

Author:  Peter [ Fri Dec 21, 2012 8:03 pm ]
Post subject:  Re: examples of bad code (and why) ?

z=x/++x

Author:  Fred [ Fri Dec 21, 2012 9:55 pm ]
Post subject:  Re: examples of bad code (and why) ?

M$?

Author:  Fred [ Mon Mar 18, 2013 3:58 pm ]
Post subject:  Re: examples of bad code (and why) ?

Code:
    try
    {
      // Make one-line call
    } catch (Throwable e)
    {
      throw new Exception(e);
    }


Catching a throwable, sometimes, maybe, OK, rethrowing as a checked exception, what? :-/

Author:  russian [ Mon Dec 30, 2013 3:16 am ]
Post subject:  Re: examples of bad code (and why) ?

I believe
Code:
a = a >> 1;

is bad code.

And some people do agree with me - http://stackoverflow.com/questions/2580 ... e-into-shi

There is the whole http://code-wtf.livejournal.com/ on this - I know it's a bit in Greek but most of it is code anyway :)

Author:  Fred [ Mon Dec 01, 2014 8:38 am ]
Post subject:  Re: examples of bad code (and why) ?

Working on some horrendous code at the moment. Most of it is fairly average and normal, but a certain person did some stuff to it in the past that has rendered it nearly unusable now. The only example that I can succinctly post here is the following:

Removed 770,000 rows from a db table, none of which were used. This took over an hour to achieve. The database has no forreign key constraints. WTF. I can't explain more, really, but the 770 were autogenerated rows with no value... bleh.

Fred.

Page 3 of 3 All times are UTC [ DST ]
Powered by phpBB® Forum Software © phpBB Group
http://www.phpbb.com/