DIYEFI.org Forum

Legend! Looks great, can't wait to give it a whirl. I can always hack my code to make it work with yours temporarily ;-)

Fred.

One thing to keep in mind. The HEX display on the main tab isn't aware that payload IDs can overlap, so it's going to show the wrong payload ID when using the memory block request stuff.

Question, have you made the assumption that the location IDs are sequential? I can't seem to find them in the code, only the names in a long list. If I just add items to the list, will it just use another number up? If I put gaps in the numbering, will it break your work?

I'm just curious about the ease with which I can add more location ids and what rules I have to follow due to your implementation. I don't mind using sequential ones for now, but I was intending to chunk them up later for grouping reasons.

Cheers!

Fred.

From what you're asking me, we might as well say the code is not ready for prime time, or even tinkering. If you found the giant list of block IDs, you should have noticed they had their IDs with them. If that's not the case then Aaron has removed them and God knows what's going on anymore.
I'd just say for now it's not finished, and you have to wait.

You want me to tidy it up Ben, or you happy to continue?

Pushed a commit adding the header flags to your branch

I don't mind if you finish it off for me one bit. I'm gunna be busy for at least the rest of today, and probably some of tomorrow. So if you can wrap your head around what I was trying to do and get it finished, more power to you. Just let me know if you finish it so I don't go working on it again.

Also I'm sure there are a couple hidden things you'll need to clarify with Fred along the way, so keep him on a short leash.

BenFenner wrote:If you found the giant list of block IDs, you should have noticed they had their IDs with them.

I found them just now (missed it before) but they are just part of the name, not specified explicitly. You can blame me as I didn't dish out the requirements well enough.

Say I change from 0 1 2 3 .... 25 26 27 28 to

1
2
3
4

100
101
102

200
203
204

Then your stuff won't work :-)

I actually need to make that change to get around another issue (or turn off an optimisation perhaps) so we'll need a more configurable way at some point.

Right now though, it worked and worked well and has provided a bunch of good data for Aaron to look at and play with :-)

Thanks again, and don't be so hard on yourself! :-p

Fred.

BenFenner wrote:so keep him on a short leash.

He's too fast for a leash

Yeah ill have a looky

Fred wrote:I found them just now (missed it before) but they are just part of the name, not specified explicitly.

You want to know why? *gasp* Because it's not finished!

=D

They were there as a note-taking thing. Never meant to stay there.

Fair enough. I just hacked some of aarons stuff to make it receive the replies and have overall raised no fewer than 6 mantis issues ;-) Thanks! :-)

70 - 75 inclusive are a result of testing made possible by you!

That ought to keep you both busy for a while ;-)

Fred.