Ben's messing aroung with FreeEMS-Tuner code

[sry_not4sale]

Your doing great Fred, don't fret!

Heaps to do on the Tuner too, so its not like either of us are holding up the other.

[sry_not4sale]

Yah, the code was easy to follow for a python noob like me.

I actually noticed the packet diagnostics output could use some work. Good idea. Sounds like a good next job for me. Let me know when I should download the newest version to start from. (Probably won't get to this until tomorrow, as it's the end of the work day where I live). Also where is the list of Payload ID -> Human Readable Name? Fred?

Do you wanna start your own thread in this section? Or even a new thread for every major job? I dunno, just don't want this to turn into a 100 page thread really quickly

[Fred]

Long threads are a sign of a lively forum! :-) Enjoy it!

[Fred]

Given that we won't have bigger packets than just over 2k, I think 16 bit line numbers are enough :

Code: Select all

 0000:  49 44 33 03 00 00 00 00  01 76 50 52 49 56 00 00  ID3......vPRIV..
 0010:  00 27 00 00 57 4d 2f 4d  65 64 69 61 43 6c 61 73  .'..WM/MediaClas
 0020:  73 50 72 69 6d 61 72 79  49 44 00 bc 7d 60 d1 23  sPrimaryID..}`.#
 0030:  e3 e2 4b 86 a1 48 a4 2a  28 44 1e 50 52 49 56 00  ..K..H.*(D.PRIV.
 0040:  00 00 29 00 00 57 4d 2f  4d 65 64 69 61 43 6c 61  ..)..WM/MediaCla
 0050:  73 73 53 65 63 6f 6e 64  61 72 79 49 44 00 00 00  ssSecondaryID...
 0060:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 50 52  ..............PR
 0070:  49 56 00 00 00 0e 00 00  50 65 61 6b 56 61 6c 75  IV......PeakValu
 0080:  65 00 ff 7f 00 00 50 52  49 56 00 00 00 11 00 00  e.....PRIV......
 0090:  41 76 65 72 61 67 65 4c  65 76 65 6c 00 7f 1b 00  AverageLevel....
 00a0:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
 00b0:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
 00c0:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
 00d0:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
 00e0:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
 00f0:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
 0100:  ff fb 90 64 00 00 00 00  00 00 00 00 00 00 00 00  ...d............
 0110:  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
 0120:  00 00 00 00 58 69 6e 67  00 00 00 0f 00 00 2d 6e  ....Xing......-n
 0130:  00 49 c8 4b 00 02 05 07  0a 0d 10 12 15 17 1a 1c  .I.K............

[Fred]

http://freeems.aaronb.info/tracker/view.php?id=45

Ben, the docs are available now, as is the source code.

Another thing worth doing is mapping error codes to error descriptions for display and displaying debug packets data as the plain text it is.

Fred.

[BenFenner]

I see the __init__.py files now... Maybe I just had a brain fart and missed them.

Anyway, on to the human readable names.

Look about right?

[sry_not4sale]

Thats great, can you removed the bytes underneath the names? And rename the column to just "Id"?

Good work!

Do you know much about patching and diffs?

[BenFenner]

Thats great, can you removed the bytes underneath the names? And rename the column to just "Id"?

Done (see attachment).

Do you know much about patching and diffs?

I know all about diffs... Patching, not so much. I assume we're trying to find a way so I don't have to post code here anymore?

[jharvey]

Ohhh, I like that human readable stuff.

[BenFenner]

I've got the changes made. Now I just need to figure out git so I can commit them. Here I go!

Edit: Git is a pain in the butt. I actually managed to "clone" the repository, but I can't "push" to it. Maybe that's by design?

Here's the recent changes anyway:
gui/commsDiagnostics.py
protocols/__init__.py