Page 1 of 2
You have almost talked me into it.
Posted: Sat Jan 17, 2009 11:00 pm
by johnsop1
I have been looking at the site and am impressed with what I see so far.
If finances permit I will be buying some hardware in the next few weeks.
Fred, you may be sorry!! I might have some comments on your code.
Philip L Johnson
The original GCC Megasquirt guy.
Re: You have almost talked me into it.
Posted: Sat Jan 17, 2009 11:18 pm
by Fred
Philip L Johnson - The original GCC Megasquirt guy.
Wow! Welcome along :-)
johnsop1 wrote:I have been looking at the site and am impressed with what I see so far.
Well, all the intention is still there, but it's a bit out of date. Glad you like it anyway :-)
Fred, you may be sorry!! I might have some comments on your code. :-)
I'm looking forward to them! Beware though, I argue back ;-) If your justifications are good and I have no better reason for the stuff I've done then you'll get your way for sure. Bring it on!
(PS, I'm a Java dev hacking C, I could do with some education by someone with more experience)
Regards,
Fred.
Re: You have almost talked me into it.
Posted: Sat Jan 17, 2009 11:32 pm
by Fred
The tail of the comments thread is here :
http://www.diyefi.org/forum/viewtopic.p ... ead#unread
And the bug tracker is here :
http://freeems.aaronb.info/tracker/
Feel free to use whichever is more suitable for the item you find.
I do know a lot of stuff is wrong with it, but I have priorities and I'm working on those over and above some other things. Try me anyway regardless of what it is :-)
Also, please get the code from github.com so that you have the latest and not something thousands of changes out of date. You don't need an account if you just want to review it, but you do need one if you want to contribute in a low overhead way.
Thanks for all your GCC ms2 efforts in the past, I'm always appreciative even if I sound the opposite at times.
Fred.
Re: You have almost talked me into it.
Posted: Sun Jan 18, 2009 12:50 am
by jbelanger
Fred wrote:Thanks for all your GCC ms2 efforts in the past
+1
That was a major step that started a whole new development.
Jean
Re: You have almost talked me into it.
Posted: Sun Jan 25, 2009 2:42 am
by johnsop1
I'm in.
Hardware arrived a few days ago. I wired up power, the com port and then downloaded firmware.
It worked!!! I even make a few firmware changes that saved a few bytes.
Time to put together a test rig. Where is my soldering iron and LEDs?
Re: You have almost talked me into it.
Posted: Sun Jan 25, 2009 9:02 am
by Fred
johnsop1 wrote:Hardware arrived a few days ago. I wired up power, the com port and then downloaded firmware.
Careful, the regulator on the board A only supplies 1/3 what the PLL clocked CPU needs and B isn't heatsinked anywhere near enough. You need to do something about that really. I'm yet to write up a guide on removing the old regulator and building a simple 5v supply to power it. Perhaps you could document it as you go? I've asked a few others too but so far they've been busy maintaining their cars etc.
It worked!!! I even make a few firmware changes that saved a few bytes.
Hmmm
It worked!!! I even make a few firmware changes that saved a few bytes. And pushed them up to github but forgot to issue a pull request.
Yes?
It worked!!! I even make a few firmware changes that saved a few bytes. And emailed them, but to the wrong address.
Maybe?
It worked!!!
Why do you sound so surprised?? :-)
Let me (or Aaron or Sean or Ben) know if you need any Git help at all.
Fred.
Re: You have almost talked me into it.
Posted: Sun Jan 25, 2009 9:19 am
by Fred
Also...
johnsop1 wrote:I'm in. Hardware arrived a few days ago.
Please find the time to produce the compulsory mug shot with card :
http://i260.photobucket.com/albums/ii15 ... ekspec.jpg
http://i260.photobucket.com/albums/ii15 ... s/diy1.jpg
http://i260.photobucket.com/albums/ii15 ... d-Spec.jpg
http://i260.photobucket.com/albums/ii15 ... 0_7044.jpg
:-)
There are actually 3 more other guys + you that haven't posted their mug shot yet! Abe, Aaron, etc, get on with it!
Fred.
Re: You have almost talked me into it.
Posted: Sun Jan 25, 2009 9:35 pm
by johnsop1
It worked!!! I even make a few firmware changes that saved a few bytes. And pushed them up to github but forgot to issue a pull request.
This git stuff is a little confusing for a noob. I made a repository and put in my changes, but it looks like it takes a while for the github web frontend to catch up. Consider this a pull request.
Why do you sound so surprised??
Not surprised, excited!
Careful, the regulator on the board A only supplies 1/3 what the PLL clocked CPU needs and B isn't heatsinked anywhere near enough. You need to do something about that really. I'm yet to write up a guide on removing the old regulator and building a simple 5v supply to power it. Perhaps you could document it as you go? I've asked a few others too but so far they've been busy maintaining their cars etc.
I used a 5 volt 6 amp wall wart type power supply and soldered a jumper from pin 1 to pin 3 on the voltage regulator. Works good.
Please find the time to produce the compulsory mug shot with card :
Working on it.
Re: You have almost talked me into it.
Posted: Sun Jan 25, 2009 11:08 pm
by Fred
Don't take me too seriously ;-)
http://github.com/johnsop1
It doesn't look like you pushed your changes back up? When you have figured that out let me know :-)
Did you see the conceptual guide I did a few days ago for Karri? I didn't get into detail but it's not too hard, you can get me or Aaron or Sean or Ben to help you out with the Git stuff any time. PM for aim/msn/gtalk details and/or phone numbers, you are welcome to call.
Basically what you want is a branch locally that you can pull my stuff straight to. Then you can merge the local branch with your master locally and push the result back up for me to pull down and merge into mine.
git branch <branch name> <revision (choose one from before your changes)>
then edit .git/config to be similar to this :
Code: Select all
/home/user/workspaces/home/freeems-vanilla/src> cat ../.git/config
[core]
repositoryformatversion = 0
filemode = true
[remote "origin"]
url = git@github.com:fredcooke/freeems-vanilla.git
fetch = +refs/heads/*:refs/remotes/origin/*
[remote "seansrepo"]
url = git://github.com/seank/freeems-vanilla.git
fetch = +refs/heads/*:refs/remotes/seansrepo/*
[remote "aaronsrepo"]
url = git://github.com/srynot4sale/freeems-vanilla.git
fetch = +refs/heads/*:refs/remotes/aaronsrepo/*
[remote "philj"]
url = git://github.com/johnsop1/freeems-vanilla.git
fetch = +refs/heads/*:refs/remotes/johnsop1/*
[branch "master"]
remote = origin
merge = refs/heads/master
[branch "public"]
remote = origin
merge = refs/heads/master
[branch "release"]
remote = origin
merge = refs/heads/release
[branch "seank"]
remote = seansrepo
merge = refs/heads/master
[branch "aaronb"]
remote = aaronsrepo
merge = refs/heads/master
[branch "philsmaster"]
remote = philj
merge = refs/heads/master
note the difference between my master and my links to everyone elses, the format is different for private/public.
here is what i just did :
Code: Select all
/home/user/workspaces/home/freeems-vanilla/src> git checkout philsmaster
Switched to branch "philsmaster"
/home/user/workspaces/home/freeems-vanilla/src> git pull
From git://github.com/johnsop1/freeems-vanilla
* [new branch] master -> johnsop1/master
* [new branch] release -> johnsop1/release
Updating b655eb5..9d9d0be
Checking out files: 100% (112/112), done.
Fast forward
<big snip because i branched you at 0.0.18 :-) >
Fred.
Re: You have almost talked me into it.
Posted: Tue Jan 27, 2009 12:15 am
by johnsop1
I figured out how to push my changes. They are on github now.
