You have almost talked me into it.

Post by **Fred** » Tue Jan 27, 2009 1:42 am

Cool :-)

I like the checksum and strcpy changes, but I feel the comms one is best left verbose. I reckon it's easy to miss that ++ on the end, but impossible to miss the whole extra line. Besides, it compiles to the same binary, so nothing saved ;-) Lots of stuff is verbose over efficient by choice and design.

How would you feel about starting on a missing tooth decoder? That is something we could really do with that doesn't have an owner yet.

You know the old mantra :

Make it work
Make it right
Then make it fast ;-)

Fred.

PS, pretty graph : http://github.com/johnsop1/freeems-vanilla/network

johnsop1 · Post by **johnsop1** » Tue Jan 27, 2009 2:27 pm

How would you feel about starting on a missing tooth decoder? That is something we could really do with that doesn't have an owner yet.

Thats my plan. The first step (I started last night) is writing a program that wiggles a bit on my PC LPT port to simulate missing tooth wheels at various rpms.

AbeFM · Post by **AbeFM** » Thu Jan 29, 2009 7:29 pm

Oh, god, the guilt!

I need to put in that regulator I found, and get Git set up. Certainly the paste it in the web front end works, but us useless folks like GUI's...

Post by **Fred** » Fri Jan 30, 2009 12:07 am

Good to see some cross team motivation happening there! Thanks Phil! ;-)

Fred.

EDIT Phil, just hit me up if you want any major structural changes to facilitate the decoder. I am planning to write a scheduler very soon to handle the event information parsing (not sure if it will be good or not) but stuff like init etc will need some attention. The init that is currently default should be fine for you though I guess. Probably best to wire your setup as per Seans new setup/idea. I'll mod mine to conform soon enough.

Post by **Fred** » Mon Feb 02, 2009 2:28 am

Phil, I don't think you have your global .gitconfig setup correctly (or at all) as your commits show up as philip rather than something more unique. I just noticed the same about Sean so I've told him to sort his out too :-)

Fred.

johnsop1 · Post by **johnsop1** » Mon Feb 02, 2009 3:59 am

I wrote some very rudimentary code that seems to be able to detect missing teeth. It is supposed to be very cold here this week so I should have some time for coding. With luck I will have something worth committing to git near the end of the week.

I will also take a look at .gitconfig before I do the next commit.

Post by **Fred** » Mon Feb 02, 2009 7:19 am

Awesome news Phil :-)

One thing though, make lots of commits! With git you don't have to worry about committing broken stuff because you only share with the world when you are ready and it works. The nice thing is that you can then keep a local commit history for the purposes of roll backs during development etc.

Lot's of small changes make merging easier too, but that shouldn't be an issue as you will be pretty much confined to one file doing that.

The small commits also give you a sort of incremental creation path too, rather than x file just appeared working all of a sudden :-)

Fred.

Post by **Fred** » Mon Feb 02, 2009 7:26 am

For example, right now you have a rudimentary working version which you should probably record so that if your next round of improvements don't work out you have something to go back to :-)

Fred.

Post by **Fred** » Thu Feb 05, 2009 2:12 am

http://www.diyefi.org/forum/viewtopic.php?f=8&t=577

New thread for the decoder and discussion about it :-)

Fred.

DIYEFI.org Forum

You have almost talked me into it.

Re: You have almost talked me into it.

Re: You have almost talked me into it.

Re: You have almost talked me into it.

Re: You have almost talked me into it.

Re: You have almost talked me into it.

Re: You have almost talked me into it.

Re: You have almost talked me into it.

Re: You have almost talked me into it.

Re: You have almost talked me into it.