DIYEFI.org Forum

Post here if you want others to check your work. Post here if you want to check the work of someone else on one of the projects, whether they ask for it or not.

I currently have Jeff and Sean up for review on the firmware. I'd like more variety in case they are busy, though. I run most of my commits directly to issues, so, if you'd like to review my firmware work please sign up on the tracker and let me know here and I'll send something your way to check.

Thanks in advance!

Fred.

https://github.com/pjohns30/freeems-van ... 16890fd0df

After sending one message it repeats that message over and over forever. I'm stuck to say the least.

Edit: This problem seems to be a feature of the CAN protocol. So no need for a code review, but here's an updated link anyway.
https://github.com/pjohns30/freeems-van ... 14a3d1cbb8

w/CAN, you need someone else on the bus to assert the line and indicate that a frame was actually put out there error free. Without that the 'emitter' will begin sending error frames .. with enough of those, you begin to get into things like bus_off conditions where it takes itself off of the bus. I don't want to clog this thread up, so email me if you need some help.

Get a cheapo chinese CAN device - this works very well for me. Best 30$ I spent in a long time (it does some other things too).

EssEss wrote:I don't want to clog this thread up

LOL! You're the last person whose posts would be unwelcome in this thread, or any thread, for that matter. If anything, best to split it off into another thread and link to that from here. Keeping it visible helps others learn through the same process.

Thanks for your input! Good info for CAN n00bs (such as me).

Fred.