BenFenner's OLV development diary (comments welcome).

OpenLogViewer is a cross-platform data log viewing application originally written by Gufi and new developed and maintained by Ben and Fred. Discuss all things OLV here!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: BenFenner's OLV development diary (comments welcome).

Post by Fred »

Like this, perhaps:

Image

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: BenFenner's OLV development diary (comments welcome).

Post by Fred »

Ben, just reviewed latest work! App is feeling good! Better than ever, in fact! :-)

Re the snapping to points, it's fine how it is. The current behaviour appears to be to snap to the side away from the edge your on when you cross 50% from the edge to the inner point. That leads me to believe that the code is doing something weirdly. I'd have a single var for "distance between any two points" and know which two points I was between, even if one wasn't visible, and snap to the edge (and the values of the invisible one) or the inner one, depending upon where it was relative to the virtual position of each.

The other thing that I noticed is that when you have the end of the data in the centre of the screen, when you move the mouse into the black abyss it snaps to imaginary points instead of floating like it does at the end.

Think about those, BUT, don't do anything with them, unless it's bothering you, there are way more important things to do, like zooming smoothly/out more, etc.

Thanks for your awesome work! :-)

Fred.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: BenFenner's OLV development diary (comments welcome).

Post by Fred »

http://download.oracle.com/javase/tutor ... layer.html
http://download.oracle.com/javase/tutor ... ndows.html

I think in future we may need to add some polish to your awesome UI goodness by removing the title bars and shit :-) Think some sort of media player feel. J7 stuff, though...

http://java.sun.com/products/java-media ... phics.html

Maybe worth a read too.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
BenFenner
LQFP144 - On Top Of The Game
Posts: 360
Joined: Wed Jul 09, 2008 3:15 pm

Re: BenFenner's OLV development diary (comments welcome).

Post by BenFenner »

Zooming out beyond a 1:1 data:pixel ratio is usable in the dev branch and just needs a little polish now before going to the prod branch.

Image
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: BenFenner's OLV development diary (comments welcome).

Post by Fred »

Awesome work, Ben! :-)
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: BenFenner's OLV development diary (comments welcome).

Post by Fred »

Re key bindings, one comment:

Using "control + scroll" is not an option because on the mac it means OS level zoom in/out of the entire screen. Just FYI.
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
BenFenner
LQFP144 - On Top Of The Game
Posts: 360
Joined: Wed Jul 09, 2008 3:15 pm

Re: BenFenner's OLV development diary (comments welcome).

Post by BenFenner »

You can now scroll the graph all the way to the end of the screen in both directions. And it automatically centers and zooms the graph to fit upon initial loading. No new screen shots for now. =(
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: BenFenner's OLV development diary (comments welcome).

Post by Fred »

Ben, new min/mean/max thing is AWESOME, but it needs 6sig figs max for anything with a fractional component. The exception to that is big numbers, ie, 1000000 should get zero dp. other than that, winner! :-)
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
Fred
Moderator
Posts: 15431
Joined: Tue Jan 15, 2008 2:31 pm
Location: Home sweet home!
Contact:

Re: BenFenner's OLV development diary (comments welcome).

Post by Fred »

Thinking again.... sig figs for the centre one should be same as max of min/max sig figs. so if i have 0.0 and 1.0 and the middle one is 0.666666666666 it should just be 0.7 not 0.666666 make sense?
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!
User avatar
BenFenner
LQFP144 - On Top Of The Game
Posts: 360
Joined: Wed Jul 09, 2008 3:15 pm

Re: BenFenner's OLV development diary (comments welcome).

Post by BenFenner »

Yes that makes sense. If you still want it, I can do that. For now I think the way I've done it will be easier to read.
(Auto-image resizing is still sometimes(?!) ruining my images on the forum. )

Zoomed out:
Image

Zoomed in:
Image
Post Reply