View unanswered posts | View active topics It is currently Mon Oct 21, 2019 1:07 am



Reply to topic  [ 268 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6 ... 27  Next
Daily WTF 
Author Message
Moderator
User avatar

Joined: Tue Jan 15, 2008 2:31 pm
Posts: 15340
Location: Home sweet home!
Yeah, that's just an organisational thing really...

Putting in new code however and calling it "release" is what Lance (I can't believe I am agreeing with him) was complaining about all along. Lance has it wrong too, he releases only when finished and tested. What you want is to release everything and just name them all appropriately so people know what they are getting...

Hence the downloads page refers to the code as "pre alpha" which it is. Also, the 0.0. in front of each number are a bit of a clue!

New features in a release is borderline unethical IMO.

Fred.

_________________
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!


Wed Apr 23, 2008 6:53 pm
Profile WWW
Moderator
User avatar

Joined: Tue Jan 15, 2008 2:31 pm
Posts: 15340
Location: Home sweet home!
Quote:
2.0.0 is now the "Stable" release. Changed since the last RC are:

1) New sync count gauge, along with more lenient sync code which allows loss of sync due to too many or too few teeth up to three times in a row before resetting ignition.
2) Fixed a problem that caused the PWM output in PWM closed-loop idle to not work in some situations.
3) Fix for Neon COP mode
4) Fix for Oddfire (Simple false-trigger protection changed)
5) Fix for Rover ignition modes (cut 'n paste problem)
6) Fix outputs so that generic output IAC1 is actually IAC1, IAC2 is actually IAC2, and make all other outputs work around the generic outputs


Image

At least there was a full stop between stable and changed. Having them in the same sentence would just have been too much.

For those wondering, the correct approach would have been to follow up RC2c with RC3 and let the users try it for a while... then rename it to 2.0.0 and rerelease it.

That is the point of an RC = Release candidate, i.e. you try it out, and if it's sweet, you roll with exactly that as your release.

You don't arbitrarily name one 2.0.0 with a bunch of new code in it or you get this in the first post after your release :

http://www.msextra.com/viewtopic.php?p=185390#185390

_________________
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!


Mon Apr 28, 2008 10:31 am
Profile WWW
Moderator
User avatar

Joined: Tue Jan 15, 2008 2:31 pm
Posts: 15340
Location: Home sweet home!
Image

What is wrong with this picture?

Mental note : do not let anyone else build your stuff!

_________________
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!


Mon Apr 28, 2008 10:49 am
Profile WWW
LQFP112 - Up with the play
User avatar

Joined: Tue Jan 15, 2008 5:14 pm
Posts: 215
^^ LOL, good find

_________________
Legal disclaimer for all my posts: I'm not responsible for anything, you are responsible for everything. This is an open and free world with no strings attached.


Mon Apr 28, 2008 3:15 pm
Profile
Moderator
User avatar

Joined: Tue Jan 15, 2008 2:31 pm
Posts: 15340
Location: Home sweet home!
I meant the map sensor, BUT, both the big diodes are funky, the to220 stuff is everywhere, the top LED resistor is off centre, none of the IC's are in sockets, the LED's are crooked as... AND the map sensor is on the WRONG side of the board, and who knows what else :-)

_________________
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!


Mon Apr 28, 2008 3:24 pm
Profile WWW
LQFP144 - On Top Of The Game
User avatar

Joined: Sat Feb 23, 2008 8:58 pm
Posts: 387
And is this rust on 2 of the TO220 transistors?

At least the proto area looks fine (as opposed to the other pic...)


Mon Apr 28, 2008 10:29 pm
Profile WWW
Moderator
User avatar

Joined: Tue Jan 15, 2008 2:31 pm
Posts: 15340
Location: Home sweet home!
No, I don't think so, just tinned on the flat only and stamped out of copper sheet :-)

_________________
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!


Tue Apr 29, 2008 6:23 am
Profile WWW
Post Whore!
User avatar

Joined: Sat Feb 16, 2008 12:11 am
Posts: 629
Location: Sunny San Diego
Quote:
2.0.0 is now the "Stable" release. Changed since the last RC are:

1) New sync count gauge, along with more lenient sync code which allows loss of sync due to too many or too few teeth up to three times in a row before resetting ignition.
2) Fixed a problem that caused the PWM output in PWM closed-loop idle to not work in some situations.
3) Fix for Neon COP mode
4) Fix for Oddfire (Simple false-trigger protection changed)
5) Fix for Rover ignition modes (cut 'n paste problem)
6) Fix outputs so that generic output IAC1 is actually IAC1, IAC2 is actually IAC2, and make all other outputs work around the generic outputs

Oh my SHIT.

1? that's ridiculous. You put out "stable" code which fires the spark plugs without knowing where the engine is and you haven't released it for beta testing yet?

I mean, ok, some things I could see as genuine mistakes, but that's just retarded. And I could have told you this would happen, they were too quiet too long for them to either release it as is or to put out another RC, which would have been a good idea, but then, why is it an RC? Why not a beta? There's no shame in betas. the first RC should have no differences in the feature list from the release. A stable release should be the last beta, with all the bugs fixed.

Things like 3-6 are good, it would be nice to have more details.

As to #2, well, I've had issues with PWM idle. How do I know what they fixed? Should I try this experimental 'stable' code, to see if it helps with this PWM issue, or is it the PID control after all?

Wow. I'm just amazed.


Tue Apr 29, 2008 9:13 am
Profile ICQ YIM
Moderator
User avatar

Joined: Tue Jan 15, 2008 2:31 pm
Posts: 15340
Location: Home sweet home!
3 - 6 are NOT good, a "bugfix" can EASILY break something else esp in code like that. They have proven that happens more than once now.

I disagree, betas can have new minor features and changes etc, but RC's can only have bug fixes in my opinion. There is probably an official reference for this stuff around somewhere. Version number changes of some level should indicate a broken/changed API (in this case anything in the INI/serial comms/data structure = API change).

it should go like this :

code that is just written and not at all even run = pre alpha
shonky poorly thought out untested code = alpha (hence my code is pre alpha LOL)
code that is run and used a bit etc = beta
code that has seen decent usage under beta conditions and come through mostly OK + some bug fixes = RC1
later RC should be same as RC1 in all respects with ONLY issues fixed in a way that is well tested and thought through
when the last RC is well tested, it goes to release status unchanged

Fred.

_________________
DIYEFI.org - where Open Source means Open Source, and Free means Freedom
FreeEMS.org - the open source engine management system
FreeEMS dev diary and its comments thread and my turbo truck!
n00bs, do NOT PM or email tech questions! Use the forum!
The ever growing list of FreeEMS success stories!


Tue Apr 29, 2008 9:21 am
Profile WWW
Post Whore!
User avatar

Joined: Sat Feb 16, 2008 12:11 am
Posts: 629
Location: Sunny San Diego
That's what I was trying to say, I don't know what I actually said. It's 3 am and my four cups of decaf coffee have done nothing for me.


Tue Apr 29, 2008 9:24 am
Profile ICQ YIM
Display posts from previous:  Sort by  
Reply to topic   [ 268 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6 ... 27  Next

Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group
Designed by ST Software for PTF. ColorizeIt.